[eas-cli] Deduplicate simulator --type flag options - #4321
Open
expo-tuft[bot] wants to merge 1 commit into
Open
Conversation
expo-tuft
Bot
force-pushed
the
tchayen/simulator-type-flag-duplicate
branch
from
August 31, 2026 20:02
00d0985 to
685dd66
Compare
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4321 +/- ##
==========================================
+ Coverage 65.38% 65.39% +0.01%
==========================================
Files 1058 1058
Lines 49090 49091 +1
Branches 10353 10353
==========================================
+ Hits 32095 32096 +1
Misses 16879 16879
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
expo-tuft
Bot
force-pushed
the
tchayen/simulator-type-flag-duplicate
branch
from
August 31, 2026 20:26
685dd66 to
9b8033d
Compare
Co-authored-by: tchayen <5769281+tchayen@users.noreply.github.com>
expo-tuft
Bot
force-pushed
the
tchayen/simulator-type-flag-duplicate
branch
from
August 31, 2026 20:44
9b8033d to
2aa55b2
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas simulator --helplistsweb-preview-onlytwice in the--typeoptions.How
DeviceRunSessionType.ServeSimandDeviceRunSessionType.WebPreviewOnlyboth map toweb-preview-only, and the flag took its options straight from that record's values. A dedupedDEVICE_RUN_SESSION_TYPE_FLAG_OPTIONSnow feeds botheas simulatorandeas simulator:list.Test Plan
eas simulator --helpandeas simulator:list --helpeach showweb-preview-onlyonce. Passing--type web-preview-onlystill resolves to theWebPreviewOnlyenum, which the existing mapping test covers.