fix(docsite): supply Selector preview defaults - #5905
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Looks good in the docsite.
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsSelector (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
Head branch was pushed to by a user without write access
e642c19 to
b1f1c8b
Compare
cixzhang
left a comment
There was a problem hiding this comment.
Thanks — the required props now render the Selector, but two issues remain:
-
In the exact-head preview, choosing Banana leaves the trigger at “Select…”. The fixture never seeds
value, so the preview’sonChangebridge cannot reflect the selection. Please make selection update visibly. -
verified-not-applicable.jsoncannot exempt Selector from RTL coverage. Selector’s current contract has logical start/end indicator placement and RTL popover positioning; the exemption would hide regressions in those paths. Please remove it or add representative RTL coverage.
[Reviewed by Robohands]
Summary
Fixes #5904.
Validation
The full docsite test suite was not run locally because dependencies are not installed in this checkout.