Skip to content

fix(docsite): supply Selector preview defaults - #5905

Open
Soumoditya wants to merge 2 commits into
facebook:mainfrom
Soumoditya:fix/selector-playground-defaults
Open

fix(docsite): supply Selector preview defaults#5905
Soumoditya wants to merge 2 commits into
facebook:mainfrom
Soumoditya:fix/selector-playground-defaults

Conversation

@Soumoditya

Copy link
Copy Markdown

Summary

  • add representative label and options defaults for the Selector properties preview
  • cover the extracted defaults so the required preview data cannot regress

Fixes #5904.

Validation

  • direct Selector documentation module check passed

The full docsite test suite was not run locally because dependencies are not installed in this checkout.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 3, 2026 12:57pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 2, 2026
@github-actions github-actions Bot added community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge labels Sep 2, 2026

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Looks good in the docsite.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

Selector (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 1999 -
Complexity N/A Very High (222) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.8KB 1.2KB

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

auto-merge was automatically disabled September 3, 2026 12:27

Head branch was pushed to by a user without write access

@github-actions github-actions Bot removed the needs:code-review High-risk change (new package/component/API) — needs human code review before merge label Sep 3, 2026

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — the required props now render the Selector, but two issues remain:

  1. In the exact-head preview, choosing Banana leaves the trigger at “Select…”. The fixture never seeds value, so the preview’s onChange bridge cannot reflect the selection. Please make selection update visibly.

  2. verified-not-applicable.json cannot exempt Selector from RTL coverage. Selector’s current contract has logical start/end indicator placement and RTL popover positioning; the exemption would hide regressions in those paths. Please remove it or add representative RTL coverage.

[Reviewed by Robohands]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. community Authored by a community contributor (not on the eng/design team)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Selector Properties preview renders no working component

2 participants