fix(core): add playground wrapper and defaults for LayoutHeader docsite preview - #5918
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsLayout (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
approved these changes
Sep 2, 2026
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this fixes the empty Properties preview. I verified the exact head renders “Page Title” inside Layout and the divider control updates visibly.
[Reviewed by Robohands]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5896
Adds default
childrenand aLayoutplayground wrapper toLayoutHeader.doc.mjsso the component renders a visible header preview on the docsite Properties tab.Problem
Navigating to the Properties tab for
LayoutHeaderon the docsite displayed an empty preview stage becauseLayoutHeaderhad no default child text and no parentLayoutscaffold declared in its.doc.mjsmetadata.Solution
playground.defaultswithchildren: 'Page Title'andhasDivider: trueinpackages/core/src/Layout/LayoutHeader.doc.mjs.playground.wrapperwith{ component: 'Layout' }.apps/docsite/src/__tests__/data-extraction.test.ts..changeset/layout-header-playground-wrapper.md.Acceptance Criteria Verification