Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D120940854. (Because this pull request was imported automatically, there will not be any future comments.) |
longlho
marked this pull request as ready for review
September 21, 2026 01:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some macOS command-line tools ship as installer packages, which DotSlash cannot currently represent or extract.
Add
format: "pkg"and.pkgURL inference. On macOS, expand packages withpkgutil --expand-fulland copy component payloads withditto, preserving executable permissions and symlinks without installing the package or running installer scripts. Payload paths ignore installation locations; distribution payloads merge in lexical order. Other hosts can parse these manifests but reject package extraction.Tests build real component and distribution packages with
pkgbuild/productbuild, cover paths containing spaces and apostrophes, verify payload contents and symlinks, and reject invalid packages. Full macOS and Linux test suites pass; Linux also verifies that package extraction returns an unsupported-platform error.