fix: increase OAuth token column length to 4096#31
Closed
pctablet505 wants to merge 2 commits into
Closed
Conversation
Author
|
Closing this draft — PR #30 already covers the same fix, and the repo is in maintenance mode (discussion #1543). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fastapi-users/fastapi-users#1523
When an OAuth provider signs tokens with RS256, the resulting access and refresh tokens can easily exceed the 1024 characters we were allowing for
access_tokenandrefresh_tokeninSQLAlchemyBaseOAuthAccountTable. The reporter hit this with Authentik on PostgreSQL:Another user confirmed the same failure on MariaDB:
In both cases the token cannot be persisted, so the login fails.
The fix increases both columns from
String(length=1024)toString(length=4096), matching the length the reporter is already using as a workaround by overriding the column definitions in their own model. I also added a round-trip test that writes and reads back a 2048-character access token, so we don't accidentally truncate long tokens in the future.Existing deployments will still need a manual Alembic migration (or equivalent) to widen already-created columns; SQLAlchemy won't resize them automatically.