-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: remove duplicated declarations and unreferenced code (-1,819 lines) #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
ba598f2
chore: remove unreferenced code and dead exports
fathiraz 891ad10
refactor: collapse duplicated icon and button-motion declarations
fathiraz 664ce9f
test: replace the custom toEqualValue matcher with vitest's toEqual
fathiraz 5c28c84
refactor: inline single-caller Effect service wrappers
fathiraz bcf9c44
refactor: replace derived message schemas with a hand-written Protoco…
fathiraz d79010f
chore: drop unused dependencies
fathiraz d38002d
test(background): pin bulk verb and cache behaviour before refactor
fathiraz e662bb3
refactor: collapse duplicated string helpers and drop dead exports
fathiraz 5c8f70a
refactor(background): extract the shared bulk verb runner
fathiraz 33058c5
refactor(background): replace runBulkUpdate's double dispatch with on…
fathiraz 21a316f
refactor(duplicate): extract the repeated section chrome from the modal
fathiraz 2283d04
refactor(cache): drop the fiber TTL machinery for the pattern already…
fathiraz 7944e7b
refactor(bar): collapse the duplicated overlay dismissal
fathiraz b80d119
chore: drop unused branded schemas and a redundant export
fathiraz 2e74801
refactor: inline the one-line http-service module into the runtime
fathiraz 187cc6f
refactor(ui): replace two inline modal overlays with the existing preset
fathiraz c0e7289
refactor(sprint): declare the sprint status shape once
fathiraz f07c462
refactor(ui): share one Kbd keycap across the four hand-copied versions
fathiraz 9635ecd
refactor(ui): route the inline pluralisation through lib/format
fathiraz ad4e303
refactor(stores): use setTimeout for the dismissal timers
fathiraz 7f4b9f9
refactor(background): drop the Effect round-trip from the message han…
fathiraz 14fdc7a
refactor(queue): iterate the task array instead of round-tripping a Q…
fathiraz 775f927
refactor(background): run every bulk queue through one progress runner
fathiraz 99e9a0a
refactor(background): collapse the two paginated item resolvers into …
fathiraz 3d0ca2c
refactor(ui): replace five parallel metadata switches with one copy t…
fathiraz 9e72fe9
test(bar): pin overlay open/close behaviour before refactor
fathiraz 6be3200
refactor(bar): hold the ten mutually-exclusive overlays in one slot
fathiraz 753a972
test: pin the retry, timeout, cancellation and brand-decode contracts
fathiraz a18c56f
refactor(logger): call the logger directly instead of through an Effe…
fathiraz 69e5ada
refactor(ids): brand the id types in TypeScript instead of at runtime
fathiraz 7b7288e
refactor(errors): make the tagged errors plain Error subclasses
fathiraz 24e9a46
refactor(graphql): collapse the service stack into one fetch client
fathiraz 272e12f
refactor(queue): cancel with an AbortController instead of a fiber map
fathiraz 8e6d729
chore: drop effect and @effect/platform
fathiraz 8faaa30
refactor(bar): declare the eighteen shortcuts as a table
fathiraz 1cd26af
refactor(relationships): build both dependency kinds with one task bu…
fathiraz 40c8762
refactor(bar): open every overflow overlay through one path
fathiraz 48d9331
refactor(queue): declare the tracker frame once
fathiraz e09a9b4
refactor: route two id parses and one style preset through what exists
fathiraz e9ec343
refactor(reorder): use the SectionHeader that already exists
fathiraz 8f08e7d
refactor(dom): try selector lists through one helper
fathiraz e0f1e3a
refactor(issue-detail): mount the context card through createLightDomUi
fathiraz 1db92fa
docs(tooltip): record why the Tippy wrapper cannot be simplified
fathiraz 3e60194
chore: restore the per-browser build and publish scripts
fathiraz ed43dff
fix(resolve): match hyphen-spelled item ids by issue number
fathiraz 428b53a
fix(reorder): resolve both id spellings in the reorder path too
fathiraz c3f173a
chore: drop an unused brand and two needlessly public helpers
fathiraz 2679446
docs: correct the comments the Effect removal made wrong
fathiraz ab37cab
docs: correct the claim that this repo has no tests
fathiraz 16ac47c
refactor(sprint): parse UTC dates and pick the earliest iteration once
fathiraz ca49de7
refactor(relationships): flatten the parent issue through one mapper
fathiraz bde1cca
refactor(sprint): load the sprint status through one hook
fathiraz b91c44d
refactor(token): share the PAT error banner and input styling
fathiraz daa2010
refactor(hovercard): derive the project-block meta once
fathiraz 0a75acf
refactor(hovercard): hold the loading skeleton from one place
fathiraz 9e28843
fix(sprint): show the iteration's last day instead of its exclusive end
fathiraz bd3bf9a
chore: drop four dead bindings and memoise the delete preview
fathiraz 8f969f9
chore: drop the redundant @primer/live-region-element dependency
fathiraz c2f20b6
refactor(queue): broadcast the pre-queue frame from one place
fathiraz eef7bbf
refactor(duplicate): render every issue reference through one row
fathiraz d402d4c
refactor(hierarchy): resolve the item id and the blocking pair once each
fathiraz e46930e
docs: correct the pnpm version, test count and the z-index comment
fathiraz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Each
publish:*script runs the build twice:wxt zip --browser Xalready runs a production build before creating the zip, so the leadingwxt build --browser X &&before it is redundant and doubles the release build time and dist output churn. Drop the explicitwxt buildand keep onlywxt zip --browser Xfor eachpublish:*script.Prompt for AI agents