Repository navigation
Conversation
codeon:
version: 1
authority: FWN-12
description: |-
Allow synchronous and asynchronous h2c Upgrade APIs to use RFC 8441 extended CONNECT, including buffered and streaming response paths. Advertise the connect-protocol setting consistently and add raw-peer coverage proving the HTTP/1.1 Upgrade remains bodyless while request DATA is sent on stream 3.
Tests:
- cargo fmt --all -- --check
- cargo test -p rttp_client --features 'http2,async' --test http2_prior_knowledge
- cargo test -p rttp --features 'client,http2,async' --test http2_feature
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
fewensa
deleted the
codeon/fewensa/FWN-12/a1-a5004ff44eba4f44ae6a41bdda696645
branch
October 1, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow RFC 8441 extended CONNECT request and response bodies on the HTTP/1.1 Upgrade h2c path. The Upgrade handshake remains bodyless, then shared HTTP/2 framing sends request DATA on stream 3 and supports buffered and streaming APIs. Add raw-peer regression coverage and preserve prior-knowledge negotiation, validation, and flow-control behavior.