fix(auth): replace hardcoded loading state strings with translatable string resources#2339
Open
demolaf wants to merge 2 commits into
Open
fix(auth): replace hardcoded loading state strings with translatable string resources#2339demolaf wants to merge 2 commits into
demolaf wants to merge 2 commits into
Conversation
demolaf
force-pushed
the
feat/add-localized-strings-states
branch
from
796a36f to
f517f53
Compare
demolaf
force-pushed
the
feat/add-localized-strings-states
branch
from
f517f53 to
b6694cb
Compare
Member
Author
|
/gemini review |
demolaf
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces hardcoded English loading messages with localized string resources across various authentication providers and operations (such as signing in, signing out, and deleting accounts). It also introduces new loading state properties to AuthUIStringProvider and its default implementation, along with corresponding unit tests. The review feedback suggests utilizing the custom stringProvider from the available config object instead of directly calling context.getString(...) or app.applicationContext.getString(...) in several provider helper files, ensuring that any user-supplied custom string provider is properly respected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2338 .
All
AuthState.Loadingmessages emitted during auth operations (sign-in, sign-out, delete, phone, email, etc.) were hardcoded English strings. This replaces every instance with a string resource lookup via Context.getString(R.string.fui_loading_*), making them overridable and translatable.