Repository navigation
fix(storage-resize-images): drop BUCKET_REGION options that cannot deploy - #3283
Conversation
…ploy europe-north2 and northamerica-south1 have no Cloud Functions location, and the CLI only lets a function listen to a regional bucket from the same region, so neither option can deploy.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unsupported regions europe-north2 and northamerica-south1 from the BUCKET_REGION configuration options, as Cloud Functions does not support them, and adds a test to verify this exclusion. The review feedback highlights a potential runtime TypeError in the newly added test due to a missing optional chaining operator before calling .map() on a potentially undefined options array.
CorieW
left a comment
CorieW
left a comment
There was a problem hiding this comment.
Problems
-
The README doesn't mention the gap. The kit can't serve buckets in
europe-north2ornorthamerica-south1, but the extension can. The README still says regional locations "are used as-is". Suggested wording:Cloud Functions has no location in
europe-north2ornorthamerica-south1, so the kit can't serve a bucket there. The extension can: keep using it, or move to a listed region.
Fixes #3268.
Choosing
europe-north2ornorthamerica-south1forBUCKET_REGIONfailed the deploy, because Cloud Functions has no location in either region.This removes both options.
A function in region europe-north1 cannot listen to a bucket in region europe-north2.Tested with live deploys: both regions failed before this change, and
euandeurope-north1deployed and resized. Other regions were not deployed.