Repository navigation
fix(storage-resize-images): accept only internal traffic and document the instance limit - #3287
Open
IzaakGough wants to merge 2 commits into
Open
IzaakGough wants to merge 2 commits into
IzaakGough wants to merge 2 commits into
Conversation
…ingress The kit deployed with the 2nd gen defaults of 100 instances and ALLOW_ALL ingress, so with concurrency 1 at most 100 images resized at once. Set maxInstances to the extension's 3000 and ingress to ALLOW_INTERNAL_ONLY.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the generateResizedImage function configuration to set maxInstances to 3000 and ingressSettings to 'ALLOW_INTERNAL_ONLY', aligning its behavior with the 1st generation extension. The changes are documented in the README and CHANGELOG, and corresponding unit tests have been added to verify these deployment options. There are no review comments, and I have no feedback to provide.
IzaakGough
marked this pull request as ready for review
October 26, 2026 14:59
CorieW
reviewed
Oct 26, 2026
A fixed limit of 3000 failed the deploy wherever it exceeded the regional Cloud Run quota. Ingress stays pinned to internal-only, as in the firestore-bigquery-export kit.
IzaakGough
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3275.
The resize images kit accepted traffic from anywhere, and nothing said how to resize more than 100 images at once.
This limits the function to internal traffic and documents raising the instance limit with
setGlobalOptions({ maxInstances }).Tested with unit tests, including
setGlobalOptions. Not redeployed since this revision.