Repository navigation
Return 502 when Open-Meteo fails in the weather forecast endpoint - #743
Merged
marcvergees merged 2 commits intoOct 25, 2026
Merged
Conversation
Upstream failures from openmeteo_requests (HTTP errors, rate limits, no network) are now reported as 502 WEATHER_FETCH_FAILED instead of 500 INTERNAL_ERROR. Fixes fireform-core#742
marcvergees
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #731/#732. When Open-Meteo itself failed (down, 429 rate limit, or no network),
GET /weather/forecastreturned 500INTERNAL_ERROR, the same code as a crash inside FireForm.openmeteo_requestswraps every upstream failure inOpenMeteoRequestsError, so the route now catches it before the generic handler:500INTERNAL_ERROR502WEATHER_FETCH_FAILED(message kept)500500(unchanged)This matches how the address lookup reports Nominatim failures (#741). No frontend change needed: the weather modal already shows the backend's
message.Fixes #742
Type of change
How Has This Been Tested?
TestWeatherEndpointsintests/test_api.py:test_forecast_upstream_error_is_502:openmeteo_requests.Client.weather_apiraisesOpenMeteoRequestsError→ 502WEATHER_FETCH_FAILEDwith the original message. Fails ondevelopment(500).test_forecast_unexpected_error_is_500: any other exception still gives 500.python -m pytest tests/→ 315 passedruff check app/→ all checks passedTest Configuration:
Checklist: