Repository navigation
FCE-3775 Let useSandbox choose the video codec - #615
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds optional vp8/h264 video codec selection to Sandbox requests, clearer 409 conflict errors, and public type exports.
Changes:
- Adds codec query parameters to peer-token and livestream helpers.
- Handles room configuration conflicts with clear errors.
- Exports
SandboxVideoCodecand adds tests.
| File | Summary |
|---|---|
packages/react-client/src/tests/sandbox.spec.ts |
Tests codec parameters and 409 errors |
packages/react-client/src/index.ts |
Exports SandboxVideoCodec |
packages/react-client/src/hooks/useSandbox.ts |
Adds codec support and conflict handling |
packages/mobile-client/src/index.ts |
Re-exports the codec type |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gawor270
marked this pull request as ready for review
September 23, 2026 11:42
czerwiukk
reviewed
Sep 24, 2026
czerwiukk
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
optionsargument ({ videoCodec }) togetSandboxPeerTokenandgetSandboxLivestream, after the existingroomType/isPublicargumentsvideoCodec(vp8|h264) with both requestsVideoCodecandSandboxOptionsfrom react-client and mobile-clientMotivation and Context
The Sandbox API now accepts a
videoCodecquery parameter; compositions need H.264 rooms.Documentation impact
Types of changes
not work as expected)