Preserve invalid scalar embed params - #7
Merged
Conversation
fishtreesugar
marked this pull request as ready for review
June 23, 2026 22:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
embeds_many.embeds_one.Why
A scalar item supplied to an embedded schema has no fields to map. It previously fell through to
transform_from_struct/3, whereget_params_field_value/3crashed before Ecto could validate the input.Returning the scalar unchanged allows
cast_embedto produce the expected type validation error instead of raising.Impact
Invalid scalar values for
embeds_oneand scalar elements insideembeds_manynow return normal changeset errors.Validation
mix format --check-formatted lib/params.ex test/strukt_test.exsmix test test/strukt_test.exs— 51 tests passedgit diff --check