Repository navigation
Test: scaffold .changes/*.yml template on PR open - #55
Closed
fivetran-catfritz wants to merge 3 commits into
Closed
fivetran-catfritz wants to merge 3 commits into
fivetran-catfritz wants to merge 3 commits into
Conversation
… branch Temporary, for testing the new "scaffold .changes/*.yml template on PR open" behavior from fivetran/dbt_package_automations#41. Revert to @main once verified. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fivetran-catfritz
added a commit
to fivetran/dbt_package_automations
that referenced
this pull request
Oct 7, 2026
…ges was current RELEVANT_CHANGES_YML checked the whole .changes/ path, so the scaffold job's own commit (adding .changes/TODO.yml.template) counted as "last touched .changes/" - making the three-way check think a real changelog entry existed when only the inert template did. Scoped the pathspec to .changes/*.yml specifically, which the template's .yml.template extension doesn't match. Reproduced against a live test PR (fivetran/dbt_amazon_ads#55): after the scaffold job added the template, the docs/generated status wrongly read "Missing: docs regeneration, CHANGELOG.md update" - note the absence of "a .changes/*.yml entry", which should have still been there. Verified locally that scoping the pathspec to .changes/*.yml fixes it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Test confirmed the scaffold feature works correctly, including a pathspec bug fix discovered during testing. Closing - not meant to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR to verify the new scaffold-changes-template job in fivetran/dbt_package_automations#41.
Expectation: once this PR's checks run, a `.changes/TODO.yml.template` file should appear, committed automatically.
Not meant to be merged - will close once verified.