Feat/plateaux for t0 extraction - #292
Open
jkuhl-uni wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is a pitch for an additional plot that can be generated during the extraction of the flowed energy density.
With a new kwarg, "plot_Ysl", the functions also produce a plot of the plateaus used to extract t0/w0, which (at the moment) looks as follows:
This is useful to check whether the plateau region the user gives by means of
xminin the function calls can indeed be justified by the data, which is of course crucial for a reliable extraction of t0. This is something that Patrick suggested to me during our analyses and I thought it might be worth sharing with others, as the implementation is a bit tedious when using the currently available pyerrors read routines.Please let me know what you think. I am aware that the plot has limitations in terms of customizability, see particularly ll. 93,94, which hardcodes how many plateaus are shown. Altering this would also mean to alter the signature of
_extract_flowed_energy_densitywhich is why I refrained from it for the time being.