fix(parsers): Render warned nodes - #81
Open
moshloop wants to merge 1 commit into
Open
Conversation
Keep warned nodes visually consistent with summary status while preserving failure precedence over warnings.
WalkthroughChangesWarned Test Rendering
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
testrunner/parsers/failure_format_test.go (1)
234-255: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winTest the amber styling promised by this change.
This test checks the warning icon and message, but not the
text-amber-500styling. Add a style-aware assertion or Clicky snapshot so a regression in the node/message color is detected.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@testrunner/parsers/failure_format_test.go` around lines 234 - 255, The TestPrettyRendersWarnedNodeAmber test currently verifies only the warning icon and message; extend it to inspect the rendered Clicky output and assert that the warned node/message uses the text-amber-500 styling. Keep the existing assertions intact and make the check fail if the amber style is removed or replaced.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@testrunner/parsers/failure_format_test.go`:
- Around line 234-255: The TestPrettyRendersWarnedNodeAmber test currently
verifies only the warning icon and message; extend it to inspect the rendered
Clicky output and assert that the warned node/message uses the text-amber-500
styling. Keep the existing assertions intact and make the check fail if the
amber style is removed or replaced.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 84e9a9be-04df-4126-8951-115e449c404b
📒 Files selected for processing (2)
testrunner/parsers/failure_format_test.gotestrunner/parsers/types.go
Contributor
Gavel summary
Totals: 2508 passed · 0 failed · 18 skipped · 5m48s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary by CodeRabbit