Skip to content

feat(examples): backport download_benchmark_assets to 25.9 - #2070

Merged
marcvivesmassana merged 1 commit into
release-candidate/25.9from
marc/backport-benchmark-assets-25.9
Aug 11, 2026
Merged

feat(examples): backport download_benchmark_assets to 25.9#2070
marcvivesmassana merged 1 commit into
release-candidate/25.9from
marc/backport-benchmark-assets-25.9

Conversation

@marcvivesmassana

@marcvivesmassana marcvivesmassana commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Backports the download_benchmark_assets helper from https://github.com/flexcompute/compute/pull/6942 into the release-candidate/25.9 client line.
  • Adds flow360/examples/benchmark_assets.py (pure urllib + json, no new dependencies) and exports download_benchmark_assets from flow360.examples.
  • Lets the Flow360 benchmark reproducer notebooks fetch a case's public root asset and reference data with no credentials or private project id, on the 25.9 client family the cases are validated against.

Context

The helper currently ships only on the 25.10 client (https://github.com/flexcompute/compute/pull/6942). The benchmark reproducer notebooks pin older client families (25.8 / 25.9), so the helper has to be backported to those lines for the notebooks to run as-is.

Test Plan

  • from flow360.examples import download_benchmark_assets imports cleanly.
  • download_benchmark_assets("NACA_0012", "root_assets") returns the local mesh path from the public benchmark bucket.

🤖 Generated with Claude Code


Note

Low Risk
Additive examples helper with no changes to core SDK paths; includes path-traversal checks on manifest entries before writing files.

Overview
Backports download_benchmark_assets onto the 25.9 client so benchmark reproducer notebooks can pull published case files without credentials or private project IDs.

Adds flow360/examples/benchmark_assets.py, which fetches from the public simcloud-public-1 benchmark bucket via stdlib urllib/json. Callers pass case_id and kind (root_assets for geometry/mesh snapshots, or folders like ref_data); multi-project cases can pass project_id. Downloads honor manifest layout (flat under to_folder for root assets, to_folder/<kind>/… for input data) and reject manifest paths that escape the destination root.

flow360.examples re-exports the helper in __all__ for from flow360.examples import download_benchmark_assets.

Reviewed by Cursor Bugbot for commit c6ec47b. Bugbot is set up for automated code reviews on this repo. Configure here.

Backport of flexcompute/compute#6942 to the 25.9 client line. Adds the
pure-stdlib download_benchmark_assets helper (and its export) so the
Flow360 benchmark reproducer notebooks can fetch a case's public root
asset and reference data with no credentials on the 25.9 client family.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@marcvivesmassana
marcvivesmassana merged commit f887c97 into release-candidate/25.9 Aug 11, 2026
18 checks passed
@marcvivesmassana
marcvivesmassana deleted the marc/backport-benchmark-assets-25.9 branch August 11, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants