feat(examples): backport download_benchmark_assets to 25.9 - #2070
Merged
marcvivesmassana merged 1 commit intoAug 11, 2026
Merged
Conversation
Backport of flexcompute/compute#6942 to the 25.9 client line. Adds the pure-stdlib download_benchmark_assets helper (and its export) so the Flow360 benchmark reproducer notebooks can fetch a case's public root asset and reference data with no credentials on the 25.9 client family. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
benflexcompute
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download_benchmark_assetshelper from https://github.com/flexcompute/compute/pull/6942 into therelease-candidate/25.9client line.flow360/examples/benchmark_assets.py(pureurllib+json, no new dependencies) and exportsdownload_benchmark_assetsfromflow360.examples.Context
The helper currently ships only on the 25.10 client (https://github.com/flexcompute/compute/pull/6942). The benchmark reproducer notebooks pin older client families (25.8 / 25.9), so the helper has to be backported to those lines for the notebooks to run as-is.
Test Plan
from flow360.examples import download_benchmark_assetsimports cleanly.download_benchmark_assets("NACA_0012", "root_assets")returns the local mesh path from the public benchmark bucket.🤖 Generated with Claude Code
Note
Low Risk
Additive examples helper with no changes to core SDK paths; includes path-traversal checks on manifest entries before writing files.
Overview
Backports
download_benchmark_assetsonto the 25.9 client so benchmark reproducer notebooks can pull published case files without credentials or private project IDs.Adds
flow360/examples/benchmark_assets.py, which fetches from the publicsimcloud-public-1benchmark bucket via stdliburllib/json. Callers passcase_idandkind(root_assetsfor geometry/mesh snapshots, or folders likeref_data); multi-project cases can passproject_id. Downloads honor manifest layout (flat underto_folderfor root assets,to_folder/<kind>/…for input data) and reject manifest paths that escape the destination root.flow360.examplesre-exports the helper in__all__forfrom flow360.examples import download_benchmark_assets.Reviewed by Cursor Bugbot for commit c6ec47b. Bugbot is set up for automated code reviews on this repo. Configure here.