Skip to content

Improve test posture #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NasaGeek merged 6 commits into from
Sep 1, 2026
Merged

Improve test posture #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be3e7e3
Allow overriding TCLLIBPATH in makefile
NasaGeek Aug 31, 2026
a4f1d74
Make test exit code more sensitive to failures
NasaGeek Aug 31, 2026
0331707
tests: correctly report testsuite summary.
markhindley Aug 26, 2026
297f639
Add one more cleanupTests to test file
NasaGeek Aug 31, 2026
76025df
Remove stderr prints from tests
NasaGeek Aug 31, 2026
955af1c
Fix version check test
NasaGeek Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ INSTALL_NAME = $(pkglibdir)/$(PKG_LIB_FILE)
#========================================================================

EXTRA_PATH = $(top_builddir):$(TCL_BIN_DIR)
TCLLIBPATH = $(top_builddir)
TCLLIBPATH ?= $(top_builddir)
TCLSH_ENV = TCL_LIBRARY=`@CYGPATH@ $(TCL_SRC_DIR)/library`
PKG_ENV = @LD_LIBRARY_PATH_VAR@="$(EXTRA_PATH):$(@LD_LIBRARY_PATH_VAR@)" \
PATH="$(EXTRA_PATH):$(PATH)" \
Expand Down
7 changes: 3 additions & 4 deletions tests/all.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ proc tcltest::cleanupTestsHook {} {

::tcltest::configure -testdir [file dirname [file normalize [info script]]]
::tcltest::configure {*}$argv
::tcltest::runAllTests
set testResult [::tcltest::runAllTests]


if {$exitCode == 1} {
if {$exitCode == 1 || $testResult == 1} {
puts "====== FAIL ====="
exit $exitCode
exit [expr {$exitCode || $testResult}]
} else {
puts "====== SUCCESS ====="
}
5 changes: 2 additions & 3 deletions tests/pgtcl-bulk.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ test pgtcl-14.1 {comprehensive tests} -body {
return [pg_result $res -error]
}
pg_result $res -clear
puts -nonewline stderr "\r14.1.1 $i "
}
set result 0
for {set i 0} {$i < 10000} {incr i} {
Expand Down Expand Up @@ -386,9 +385,7 @@ test pgtcl-14.1 {comprehensive tests} -body {
incr result
}
pg_result $res -clear
puts -nonewline stderr "\r14.1.2 $i $result "
}
puts stderr "\r[list result $result] "
pg_disconnect $conn

list
Expand All @@ -405,3 +402,5 @@ pg_disconnect $conn


puts "tests complete"

cleanupTests
6 changes: 4 additions & 2 deletions tests/pgtcl.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,9 +1079,9 @@ test pgtcl-9.3 {dbinfo param} -body {
lappend res [string equal $val $val2]
::pg::disconnect $conn

set match [regexp {(7|8|9|10|11|12)\.([0-9])\.([0-9])} $val]
set match [regexp {(7|8|9|1[0-9])\.([0-9])\.([0-9])} $val]
if {!$match} {
set match [regexp {^(10|11|12)\.[1-9][0-9]* \(.*} $val]
set match [regexp {^(1[0-9])\.[1-9][0-9]*} $val]
}
lappend res $match

Expand Down Expand Up @@ -1363,3 +1363,5 @@ test pgtcl-11.3 {using pg_exec with 4-byte unicode positional args} -body {


puts "tests complete"

cleanupTests
2 changes: 1 addition & 1 deletion tests/sqlite3.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,4 @@ test pgtcl-sqlite3-1.4 {import postgresql result with multiple keys} -body {
expr {$pgtcl_count == $sqlite_count}
} -result 1


cleanupTests
Loading