Skip to content

Fixed absolute symlink issue for gdb files while packing conda env #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saifulislampi merged 2 commits into from
Nov 5, 2025
Merged

Fixed absolute symlink issue for gdb files while packing conda env #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae10e14
Fixed absolute symlink issue for gdb files while packing conda env
saifulislampi Nov 5, 2025
e350641
Added comment to describe why exclude gdb files
saifulislampi Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion floability/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ def create_conda_pack_from_yml(
print(f"[environment] Post-installation script executed successfully.")

print(f"[environment] Packing environment into '{output_file}'...")

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment explaining why GDB files are being excluded from the packed environment. This would help future maintainers understand the rationale behind this exclusion (e.g., reducing package size, removing unnecessary debug symbols).

Suggested change
print(f"[environment] Packing environment into '{output_file}'...")
print(f"[environment] Packing environment into '{output_file}'...")
# Exclude GDB files to reduce package size and remove unnecessary debug symbols,
# as they are not required for running the environment.

Copilot uses AI. Check for mistakes.

@saifulislampi saifulislampi Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Add comment - # Exclude GDB debug files which contain absolute symlinks that break conda-pack

cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force"]

# Exclude GDB debug files which contain absolute symlinks that break conda-pack
cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"]

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace at the end of this line. Remove the trailing space after the closing bracket for consistency with code style.

Suggested change
cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"]
cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"]

Copilot uses AI. Check for mistakes.

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace at the end of the line should be removed for consistency with the project's formatting standards.

Suggested change
cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"]
cmd_pack = ["conda-pack", "-p", env_path, "-o", output_file, "--force", "--exclude", "share/gdb/*"]

Copilot uses AI. Check for mistakes.
subprocess.run(cmd_pack, check=True)

print(f"[environment] Environment successfully packed: {output_file}")
Expand Down