Added support for worker transfer port - #71
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CLI plumbing to configure TaskVine vine_factory worker-to-worker transfer port ranges, and updates the default conda environment requirement to a newer ndcctools version that presumably supports the new flag.
Changes:
- Add
--worker-transfer-portsCLI option and propagate it into the worker factory launch command as--transfer-port=.... - Update
environment.ymlto requirendcctools>=7.17.0. - Document
--worker-transfer-portsin the CLI reference.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
floability/workers_manager.py |
Normalizes new CLI option into worker config and forwards it to vine_factory as --transfer-port. |
floability/commands/workers.py |
Adds --worker-transfer-ports to floability workers start. |
floability/commands/argument_groups.py |
Adds --worker-transfer-ports to shared run/execute argument group. |
environment.yml |
Pins ndcctools to >=7.17.0. |
docs/reference/cli.md |
Documents the new CLI flag for run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "cores": _attr(cli_args, "cores_per_worker"), | ||
| "batch_options": _attr(cli_args, "batch_options"), | ||
| "debug_workers": _attr(cli_args, "debug_workers"), | ||
| "transfer_port": _attr(cli_args, "worker_transfer_ports"), |
Comment on lines
+207
to
+208
|
|
||
| vf_group.add_argument( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.