Use updated icon forks; make Simple Icons migration version-independent - #763
Draft
sadespresso wants to merge 1 commit into
Draft
sadespresso wants to merge 1 commit into
sadespresso wants to merge 1 commit into
Conversation
Bump material_symbols_icons_flow to ^4.2960.0 and simple_icons_flow to ^16.23.0 (both synced with upstream). Simple Icons reassigns code points every release (3370 of them moved between 16.20.0 and 16.23.0). migrateSimpleIconsToSlug mapped legacy 14.6.1 code points to 16.20.0 ones and then resolved the slug against the *bundled* font, so bumping the package would have migrated stored brand icons to the wrong brands. Regenerate the legacy table as 14.6.1 code point -> slug (limited to slugs present in the bundled build) and look slugs up directly, so future package bumps can't break the migration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FdMdLgvKZMHugJXw9JPFcz
Collaborator
Author
|
The The new fork versions aren't on pub.dev yet. This PR can't go green until they are:
The code itself was checked against local copies of both forks (through a temporary Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
material_symbols_icons_flowto^4.2960.0andsimple_icons_flowto^16.23.0. Both forks are synced with upstream in flow-mn/material_symbols_icons_flow and flow-mn/simple_icons_flow.migrateSimpleIconsToSlugmapped legacy 14.6.1 code points to 16.20.0 ones, then looked up the slug in the bundled font. Simple Icons reassigns code points every release (3370 moved between 16.20.0 and 16.23.0). On 16.23.0, users who haven't migrated yet would get the wrong brand icons.legacy_simple_icons_codepoints.dartnow maps each 14.6.1 code point straight to its slug. The table only includes slugs present in the bundled build, so it no longer depends on the package version.Testing
Ran against the local fork checkouts through a temporary
pubspec_overrides.yaml, which is not committed:flutter analyze: no errors. 13 existing warnings/infos, none icon-related.flutter test test/unit test/widget test/serialization: 270 pass. The 6 failures come from ObjectBox setup, because its native library isn't installed in this environment.pubspec.lockis unchanged. Both forks need to be published on pub.dev first, then runflutter pub get.🤖 Generated with Claude Code
https://claude.ai/code/session_01FdMdLgvKZMHugJXw9JPFcz
Generated by Claude Code