Conversation
The IntegrationManagerController page documented the constructor but never showed where to instantiate the class, and the global_addons filter reference pointed at a method that no longer applies it. Add a bootstrap example on fluentform/loaded, describe registerAdminHooks(), and correct the filter location to AddOnModule::getRegisteredAddOns().
Deploying fluentform-developers with
|
| Latest commit: |
6acadd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22146961.fluentform-developers.pages.dev |
| Branch Preview URL: | https://docs-integration-bootstrap-f.fluentform-developers.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
The
IntegrationManagerControllerpage documents the constructor but never shows where to instantiate the class, so custom integrations get bootstrapped in inconsistent places. This adds thefluentform/loadedbootstrap example — the pattern Fluent Forms Pro and sibling plugins use — and fixes the stalefluentform/global_addonssource reference.Changes
fluentform/loadedexampleregisterAdminHooks()linking to that sectionfluentform/global_addonslocation:AddOnModule -> getRegisteredAddOns()(wasAddOnModules -> showFluentAddOns()), with a pointer thatregisterAdminHooks()adds the filterHow to test
npm run dev(Node 17+: prefixNODE_OPTIONS=--openssl-legacy-provider).__construct()example.registerAdminHooks(), click the link → jumps to#bootstrapping-your-integration.fluentform/global_addons→ corrected location and the same link resolve.Anything the reviewer should know?
fluentform/global_addons"located in" line; whichever merges second needs a one-line rebase.