Repository navigation
Recognize plaintext-only and case-insensitive editable states - #2223
feritcemkahraman wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: ef22af4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe contenteditable check now accepts ChangesContenteditable value recognition
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change recognizes plaintext-only and case-insensitive editable values while retaining negative-tabindex behavior. No concrete unresolved merge risk remains. Pre-merge checks |
|
Plaintext-only editable regions currently disappear from the natural tab order returned by
tabbable(). Uppercase valid contenteditable values have the same issue: Chromium focuses these nodes natively, but the attribute fallback classifies them as non-editable and returns tabindex -1.Recognize
plaintext-onlyand case-insensitive enumerated values in the existing fallback. Explicit negative tabindex remains respected. No new APIs or dependencies.Validation:
PR Checklist
Please leave this checklist in your PR.
typeof document/window !== 'undefined'before using it in code that gets executed on load.npm run changesetlocally to add one, and follow the prompts).Summary by CodeRabbit
contenteditable="plaintext-only"or case-insensitivecontenteditablevalues such as"TRUE"are now included in natural tab order. Explicitly setting a tab index of-1continues to exclude them.