Conversation
slaemmer
force-pushed
the
UXPROD-5562-spike-anonymization-side-table
branch
from
July 27, 2026 13:38
27fff21 to
8394b1b
Compare
Replace the seven anonymization checker classes with a single AnonymizationEligibility.dueAt() function and rework the scheduled job into a two-pass evaluate/drain over a derived due-date held in mod-circulation-storage's loan_anonymization_due table. - Evaluate: stamp a due-date on one page of closed loans that have no row yet. - Drain: fetch loans whose due-date has arrived, re-check them, and strip the eligible ones (the strip deletes the row); re-stamp any no-longer-eligible. Invalidation hooks clear the relevant rows on a fee/fine closure and on any loan_history change. Adds the storage client, the eligibility kernel and its tests, and a wire-format contract test for due_at.
slaemmer
force-pushed
the
UXPROD-5562-spike-anonymization-side-table
branch
from
July 27, 2026 14:16
8394b1b to
6a4117b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The current approach to loan anonymization already can lead to wasted throughput and could sometimes lead to starvation. This would certainly be the case when user specific anonymization would be added.
This is a prototypical implementation that resulted from a spike for User specific loan anonymization. It is intended to stay a draft.
Approach
Replace the seven anonymization checker classes with a single AnonymizationEligibility.dueAt() function and rework the scheduled job into a two-pass evaluate/drain over a derived due-date held in mod-circulation-storage's loan_anonymization_due table.
Invalidation hooks clear the relevant rows on a fee/fine closure and on any loan_history change. Adds the storage client, the eligibility kernel and its tests, and a wire-format contract test for due_at.