Repository navigation
Conversation
eshulman2
commented
Sep 30, 2026
| def resolve_openai_api_key(self, api_key_env: str | None) -> str: | ||
| """Resolve a compatible endpoint credential without serializing it into policy.""" | ||
| if not api_key_env: | ||
| return self.openai_api_key.get_secret_value() |
Collaborator
Author
There was a problem hiding this comment.
P1 — prevent the legacy key from reaching an unauthenticated named endpoint. When a named openai-compatible connection omits api_key_env, its callers pass None here. If OPENAI_API_KEY is also set for legacy use, this returns that real credential and the agent/sandbox sends it as Bearer auth to the named connection's base_url. The documented no-key configuration should resolve to an empty/placeholder key; restrict this fallback to the legacy single-connection path.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-compatiblemodel backend for orchestration and sandbox agentsbase_urland environment-backedapi_key_envcredentialsOPENAI_BASE_URL/OPENAI_API_KEYconfigurationTesting
uv run pytest tests/unit -q(2202 passed)git diff --check