Skip to content

fix: align agent skills with stage execution contracts - #349

Open
eshulman2 wants to merge 1 commit into
mainfrom
fix/agent-skill-contracts
Open

eshulman2 wants to merge 1 commit into
mainfrom
fix/agent-skill-contracts

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Analysis and review containers inherited implementation and commit instructions, while several skills contradicted their runtime output schemas. This change makes stage permissions explicit, enforces read-only qualitative reviews, and aligns planning, implementation, CI, and review skills with their actual contracts.

  • Separate analysis, implementation, review, and conflict-resolution instructions; prevent review writes/shell access and non-implementation fallback commits.
  • Review complete diffs against the correct base, validate review-thread coverage and IDs, and require change-appropriate validation evidence instead of mandatory test-file quotas or assumed test success.
  • Remove forced task decomposition and repository-specific default review rules; improve uncertainty handling, documentation coverage, and skill-relative template references.
  • Render complete evaluation inputs, enforce production response schemas, preserve literal input text, and separate the default and OSAC PRD rubrics.

Validation: make lint, make test-pr, Redis-backed make test-integration, make test-e2e, all 21 skill validators, and a rebuilt sandbox image with a smoke test of read-only file access and rejection of synchronous/asynchronous mutations.

The sandbox image must be rebuilt for the new entrypoint/backend. No live-model quality or cost benchmark was run; the added tests verify deterministic contracts and execution behavior.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant