Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupted deliveries could remain stuck in Redis pending entries or be skipped because observation acceptance was mistaken for completed workflow execution. Expired ticket and effect owners could also keep writing, while incoming deliveries accumulated unbounded local tasks.
This change makes unfinished observations recoverable, rejects stale writes, and bounds delivery dispatch across new messages, pending recovery, and scheduled retries.
The implementation separates ownership, effects, queue recovery, observation handoffs, and crash testing/documentation.
Validation:
Deployment requires draining/stopping old workers before starting new workers; mixed protocol writers are unsafe. Preserve Redis data and classify legacy accepted observations without processing records as ambiguous rather than replaying them automatically. Local ownership cannot retract provider requests already in flight, and this does not promise exactly-once model execution. See docs/architecture/recovery.md and docs/operations.md.