ci: add fail-closed Required CI aggregate - #1835
Closed
gfyrag wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v3.0 #1835 +/- ##
================================================
+ Coverage 76.82% 76.84% +0.02%
================================================
Files 472 472
Lines 50356 50356
================================================
+ Hits 38685 38698 +13
+ Misses 8270 8263 -7
+ Partials 3401 3395 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 28, 2026
Contributor
✅ Approve — automated reviewThe aggregate is fail-closed, covers all mandatory jobs, and the topology contract detects omitted or stale producers. No actionable correctness defects were found. No findings. |
flemzord
approved these changes
Aug 31, 2026
Azorlogh
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds one stable GitHub Actions check named exactly
Required CIfor ordinary pull requests. It aggregates every current mandatory Default-workflow producer, moves Repository Invariants into the same dependency graph, and adds a mechanical topology contract that rejects unaggregated jobs.Why
CI currently reports failures on
release/v3.0but is not technically required. This repository-side prerequisite creates the single fail-closed check that a later repository-scoped ruleset can safely require.Product / operational motivation
Need: merges to
release/v3.0must eventually be blocked unless every mandatory repository validation succeeds.Current limitation: current checks are observable but not required, and Coverage omits mandatory producers and does not fail closed on all upstream conclusions.
Requirement / constraint: emit one stable
Required CIcheck that accepts only exact success from all mandatory producers, without changing GitHub rulesets in this PR.Evidence:
docs/technical/contributing/ci.mdanddocs/technical/architecture/repository-invariant-gates.md.Durable repository evidence:
.github/required-ci.json,scripts/required-ci, and the topology checks inscripts/check-repo-invariants.go.Technical decision
Decision: consolidate Repository Invariants into
Default, pass the complete directneedsobject to a tested fail-closed helper, and classify the only two optional/publication jobs explicitly.Why now / why proportionate: GitHub Actions cannot express cross-workflow
needs, and a small explicit contract prevents future mandatory jobs from silently escaping the aggregate.Alternatives considered: Coverage is incomplete and can pass after producer failures; duplicating invariants would create ambiguous checks; a ruleset change is intentionally deferred until real check emission is observed.
Risk
MEDIUM — this changes CI topology and future enforcement identity, but does not change product runtime behavior or any GitHub ruleset.
Validation
bash scripts/agent-checkgo test -count=1 ./scriptsyqandjqArchitecture / behavior impact
CI only.
Required CIruns withif: always()and fails unless every direct mandatory producer result is exactlysuccess. No ruleset or merge-queue configuration is changed.Review focus
Please verify the mandatory producer list, the fail-closed
toJSON(needs)handling, and the explicit optional-job classification.Known concerns
Open PR #1821 proposes a new mandatory
Tests-S3job. If it lands after this PR, its rebase must add that job toRequired-CI.needs; the new invariant is expected to fail until it does.