Skip to content

test(e2e): promote checker baseline before restore check - #1863

Merged
gfyrag merged 1 commit into
release/v3.0from
fix/restore-checker-baseline-e2e
Sep 3, 2026
Merged

test(e2e): promote checker baseline before restore check#1863
gfyrag merged 1 commit into
release/v3.0from
fix/restore-checker-baseline-e2e

Conversation

@gfyrag

@gfyrag gfyrag commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • archive the restored successor chapter before running CheckStore
  • wait for the archived state and the node-local baseline promotion window
  • retain the non-vacuous logsChecked > 0 assertion and residency checks

Root cause

The failing cluster E2E job called CheckStore after CloseChapter. A close only stages the checker baseline; ConfirmArchiveChapter promotes it to the live baseline matching the archived boundary. With no live baseline, the checker correctly skipped entry-by-entry verification and reported logsChecked = 0.

The ARCHIVED row is published before the node-local promotion hook completes, so the test retries CheckStore across that narrow post-commit window instead of sleeping.

Validation

  • env -u GOROOT GOCACHE=/tmp/ledger-e2e-gocache-1850 nix develop --command go test -race -tags "e2e,s3" ./tests/e2e/cluster -run TestCluster -ginkgo.focus="Restore chapter registry" -ginkgo.v -count=1 -timeout 5m
  • GOCACHE=/tmp/ledger-agent-check-gocache-restore-baseline bash scripts/agent-check

@NumaryBot

Copy link
Copy Markdown
Contributor

✅ Approve — automated review

The change correctly archives the restored successor chapter, waits for archival, and retries the store check until baseline-backed verification occurs. No actionable regressions were found.

No findings.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (c0a3db3) to head (6219059).

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v3.0    #1863      +/-   ##
================================================
+ Coverage         77.06%   77.11%   +0.05%     
================================================
  Files               477      477              
  Lines             51141    51141              
================================================
+ Hits              39410    39439      +29     
+ Misses             8298     8268      -30     
- Partials           3433     3434       +1     
Flag Coverage Δ
e2e 77.11% <ø> (+0.05%) ⬆️
scenario 77.11% <ø> (+0.05%) ⬆️
unit 77.11% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gfyrag
gfyrag merged commit b573adf into release/v3.0 Sep 3, 2026
17 checks passed
@gfyrag
gfyrag deleted the fix/restore-checker-baseline-e2e branch September 3, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants