test(e2e): promote checker baseline before restore check - #1863
Merged
Conversation
Contributor
✅ Approve — automated reviewThe change correctly archives the restored successor chapter, waits for archival, and retries the store check until baseline-backed verification occurs. No actionable regressions were found. No findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v3.0 #1863 +/- ##
================================================
+ Coverage 77.06% 77.11% +0.05%
================================================
Files 477 477
Lines 51141 51141
================================================
+ Hits 39410 39439 +29
+ Misses 8298 8268 -30
- Partials 3433 3434 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
flemzord
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckStorelogsChecked > 0assertion and residency checksRoot cause
The failing cluster E2E job called
CheckStoreafterCloseChapter. A close only stages the checker baseline;ConfirmArchiveChapterpromotes it to the live baseline matching the archived boundary. With no live baseline, the checker correctly skipped entry-by-entry verification and reportedlogsChecked = 0.The
ARCHIVEDrow is published before the node-local promotion hook completes, so the test retriesCheckStoreacross that narrow post-commit window instead of sleeping.Validation
env -u GOROOT GOCACHE=/tmp/ledger-e2e-gocache-1850 nix develop --command go test -race -tags "e2e,s3" ./tests/e2e/cluster -run TestCluster -ginkgo.focus="Restore chapter registry" -ginkgo.v -count=1 -timeout 5mGOCACHE=/tmp/ledger-agent-check-gocache-restore-baseline bash scripts/agent-check