Skip to content

Allow the browser-test port to be set with TEST_PORT - #28

Merged
LukasWallrich merged 2 commits into
mainfrom
test/configurable-port
Oct 21, 2026
Merged

LukasWallrich merged 2 commits into
mainfrom
test/configurable-port

Conversation

@LukasWallrich

@LukasWallrich LukasWallrich commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Lets several checkouts run npm test at the same time. The default stays 8897.

🤖 Generated with Claude Code


Summary by cubic

Lets several checkouts run npm test at the same time by setting the browser-test port with the TEST_PORT environment variable; the default stays 8897. The suite now also fails fast instead of testing another server's files when its port is already taken. The contributing docs mention the new option.

Written for commit 927e7f1. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Documentation

    • Updated browser-test documentation to explain that the test server port can be configured with TEST_PORT.
    • Clarified that the default test server port remains 8897.
  • Tests

    • Browser tests now consistently use the configured TEST_PORT value when starting the test server and connecting to it.
    • Existing support for configuring the Python executable remains unchanged.

Lets several worktrees run the browser suite at the same time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 899c4559-01ec-4cc0-9890-d5c2f3da887b
📥 Commits

Reviewing files that changed from the base of the PR and between 12f9f1f and 927e7f1.

📒 Files selected for processing: 1
  • tests/browser.test.cjs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 50e24588-c3f6-42f4-9a99-e8839d549e49
📥 Commits

Reviewing files that changed from the base of the PR and between 32441a1 and 12f9f1f.

📒 Files selected for processing: 2
  • CONTRIBUTING.md
  • tests/browser.test.cjs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Browser tests now use TEST_PORT for the HTTP server and base URL, with 8897 as the default. The test instructions document the setting.

Changes: Browser-test port

Layer / File(s) Summary
Resolve and document the test port
tests/browser.test.cjs, CONTRIBUTING.md
The browser tests use TEST_PORT for the server port and base URL, defaulting to 8897. The test instructions document the override.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 12f9f

The configurable browser-test port is consistent across implementation and documentation, with no merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: configuring the browser-test port with TEST_PORT. It matches the pull request objectives and file changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread tests/browser.test.cjs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LukasWallrich
LukasWallrich merged commit 27b6682 into main Oct 21, 2026
3 checks passed
@LukasWallrich
LukasWallrich deleted the test/configurable-port branch October 21, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant