Repository navigation
Fix mobile chart scrolling and navigation state - #35
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Disable Plotly zoom and pan in the shared renderer, allow study tables to scroll, and keep the citation dialog close action visible. Measure tab navigation overflow and switch to the existing select when needed. Consolidate URL writes so missing tab state restores Overview, history closes timelines, and shared links contain only active non-default controls. Keep legacy citation searches working and restore Browse pages. Add browser coverage for touch gestures, responsive tables and history. Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
Keep DOI-only routes on Citation Impact during initial restoration so URL cleanup preserves pending deep links. Add a history entry for user-opened timelines while replacing initial deep links, and focus the restored pane instead of the opener on history-driven closes. Cover navigation, focus, delayed loading, and cancellation with browser regressions. Validation: TEST_PORT=9205 BROWSER_CHANNEL=chromium npm test (24 passed). Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
LukasWallrich
force-pushed
the
fix/mobile-navigation
branch
from
October 21, 2026 19:32
6c09ab2 to
abeeaa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the second usability review of 21 October 2026. This was an agent-led review using simulated perspectives, not recruited participants. GPT 6.1 Sol implemented the changes; Claude reviewed them. This PR fixes C06 (phones) and C15 (navigation and URL state).
Changes
FloraCharts.plothelper setsdragmode:false,fixedrangeon every axis, andscrollZoom/doubleClickoff. Hover tooltips stay. This covers every Plotly chart, including the timelines..table-wrapnow usesoverflow-x:auto, so the citation originals table (Timeline button) and the Publication Type study tables are reachable at 390 and 768 px.tabparameter means Overview.ci-q, and oldsearch-inputlinks still work. Browse restores its page, page size and mobile page.Tests
Five new browser scenarios:
Full suite passes locally (21/21).
For review
The fixed header and footer height in landscape (a11y note 9) is unchanged.
🤖 Generated with Claude Code
Summary by cubic
Fixes mobile chart scrolling so swipes and drags scroll the page instead of zooming charts, and reworks URL/history state so back/forward restores tabs, controls, and dialogs correctly.
Chart and layout fixes
Navigation state
tabmeans Overview and back always closes an open timeline.search-inputcitation links and Browse page, page size, and mobile page still restore.Written for commit abeeaa0. Summary will update on new commits.