Repository navigation
Fix visible copy, study-type labels and number formatting - #36
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Correct FAQ display, product names and reader-facing labels. Format chart counts, small shares, intervals, exports and citation hovers consistently, and remove unused citation loading residue and the optional FECT request. Add focused browser coverage without changing scientific classifications. Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
Use integer tick spacing for small count axes so fractional auto-ticks do not produce repeated rounded labels. Warn when an upstream FAQ heading change bypasses the venue correction, and use shared count formatting throughout Citation Impact. Add browser coverage for small count axes, desktop and mobile comparisons, FAQ heading drift, and count formatting under a German locale. Full browser suite: 24 tests passed. Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
LukasWallrich
force-pushed
the
fix/copy-errors
branch
from
October 21, 2026 19:39
543526d to
f465e05
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the second usability review of 21 October 2026. This was an agent-led review using simulated perspectives, not recruited participants. GPT 6.1 Sol implemented the changes; Claude reviewed them. This PR fixes C09 and the objective errors in C13, plus related copy findings. It does not touch the outcome or row-unit vocabulary, the boilerplate caveats, or substantive caveat wording; separate proposal PRs cover those.
Changes
doi\_r,alt\_id\_r), grammar and spelling are fixed, and so is the "plugin tags…" sentence. The peer-review answer now matches the dashboard's venue categories.journal_rand thedata/disciplines.jsonlink label are gone, along with "straightforward to extend" and "Uncategorized may dominate";fect_results.jsonrequest, which returned 404 on every visit, is removed. Its only producer isrun_fect.R, which nothing deploys.Tests
Four new browser scenarios cover the assembled copy, an FAQ fixture, formatting, exports and hovers, and the low-data and unavailable states. Full suite passes locally (20/20).
For review
🤖 Generated with Claude Code
Summary by cubic
Fixes visible copy, study-type labels, and number formatting issues from the usability review: reproduction views no longer show broken sentences or mislabelled study types, and counts, percentages, and exports are formatted consistently.
Copy fixes
journal_r, thedata/disciplines.jsonlink label, "RRDB"/"rest" labels, the workflow-secrets placeholder, a "Loading…" element, and the unusedfect_results.jsonrequest that 404'd on every visit.Formatting
The FAQ correction warns when an upstream heading change bypasses the venue fix. Eight new browser tests cover copy, FAQ display and drift, formatting/exports/hovers, small-sample counts and integer ticks, and a non-English locale; the full suite passes locally (24/24). Outcome and caveat wording is unchanged; separate PRs cover that.
Written for commit 9ad6a6a. Summary will update on new commits.