Repository navigation
Fix chart labels, legends and citation timeline details - #39
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Keep timeline numbering chronological without changing stored model tie order. Reserve space for denominators, legends and phone axes; omit empty Mean Citedness tiles and balance the grid. Cover these behaviours with focused browser regressions. Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
Fill seven-tile Mean Citedness grids with a full-width first tile and two three-column rows. Debounce citation timeline redraws by 120 ms and cover resize bursts, timer resets, and closed modals. Rename the orphan-tile test to match its assertion and verify the seven-tile layout across desktop and mobile widths. Wait for the asynchronous clipboard success state before asserting it, then check that the clipboard contains the exact timeline URL. Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
LukasWallrich
force-pushed
the
fix/chart-details
branch
from
October 21, 2026 19:25
e69b906 to
28f0f1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the second usability review of 21 October 2026. This was an agent-led review using simulated perspectives, not recruited participants. GPT 6.1 Sol implemented the changes; Claude reviewed them. This PR fixes C25, the zero tile from C24, the N-label bug from C05, and legend order from C19. It also fixes clipped Plotly axis titles on phones.
Changes
Tests
Focused tests cover list and marker order, marker spacing, partial-year styling, KPI tiles, N-label bounds, legend order, and phone axis titles. Full suite passes locally (18/18).
🤖 Generated with Claude Code
Summary by cubic
Fixes chart and citation timeline issues from the second usability review, covering replication ordering and label spacing, KPI tile layout, N-label visibility, legend order, and phone axis clipping.
Written for commit 28f0f1d. Summary will update on new commits.