Skip to content

Fix chart labels, legends and citation timeline details - #39

Merged
LukasWallrich merged 2 commits into
mainfrom
fix/chart-details
Oct 21, 2026
Merged

LukasWallrich merged 2 commits into
mainfrom
fix/chart-details

Conversation

@LukasWallrich

@LukasWallrich LukasWallrich commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

From the second usability review of 21 October 2026. This was an agent-led review using simulated perspectives, not recruited participants. GPT 6.1 Sol implemented the changes; Claude reviewed them. This PR fixes C25, the zero tile from C24, the N-label bug from C05, and legend order from C19. It also fixes clipped Plotly axis titles on phones.

Changes

  • Citation timeline:
    • the replication list and marker numbers follow chronological order;
    • markers are spaced so they don't touch at 320–390 px;
    • the partial current year has lighter bars and a "partial year" label;
    • empty series are dropped from the legend;
    • copy buttons no longer include an emoji;
    • tooltips are not truncated.
  • Mean Citedness KPI tiles: zero-count tiles (such as "0 Inconclusive") are omitted, and the grid is balanced so no tile sits alone on the last row.
  • N labels: they no longer disappear when category names wrap or overlap the legend.
  • Legend order: legends follow the stack order in both Chart.js and Plotly.
  • Phones: Plotly uses automatic margins, so axis titles aren't clipped and the right axis doesn't overlap its ticks.

Tests

Focused tests cover list and marker order, marker spacing, partial-year styling, KPI tiles, N-label bounds, legend order, and phone axis titles. Full suite passes locally (18/18).

🤖 Generated with Claude Code


Summary by cubic

Fixes chart and citation timeline issues from the second usability review, covering replication ordering and label spacing, KPI tile layout, N-label visibility, legend order, and phone axis clipping.

  • Replication lists and markers now sort chronologically without changing stored tie order; markers don't touch at 320–390 px and the partial current year is dimmed and labeled.
  • Zero-count Mean Citedness tiles are omitted; seven-tile grids render as a full-width first tile plus two three-column rows, and no tile sits alone on the last row.
  • N labels stay visible when category names wrap or overlap the legend; legends follow stack order in Chart.js and Plotly.
  • Plotly uses automatic margins on phones so axis titles aren't clipped and don't overlap ticks.
  • Copy buttons drop emoji and tooltips aren't truncated. Citation timeline redraws are debounced by 120 ms so resize bursts trigger one redraw and closed modals are skipped; focused browser tests cover these behaviors.

Written for commit 28f0f1d. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4c21d593-5de8-4b6e-9e08-d1ff8246c42b
📥 Commits

Reviewing files that changed from the base of the PR and between d23f7d1 and 28f0f1d.

📒 Files selected for processing: 5
  • assets/app.js
  • assets/chart-accessibility.js
  • assets/citation-impact.js
  • assets/styles.css
  • tests/browser.test.cjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread assets/styles.css
Comment thread assets/citation-impact.js Outdated
Comment thread tests/browser.test.cjs Outdated
LukasWallrich and others added 2 commits October 21, 2026 20:24
Keep timeline numbering chronological without changing stored model tie order. Reserve space for denominators, legends and phone axes; omit empty Mean Citedness tiles and balance the grid. Cover these behaviours with focused browser regressions.

Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
Fill seven-tile Mean Citedness grids with a full-width first tile and
two three-column rows. Debounce citation timeline redraws by 120 ms
and cover resize bursts, timer resets, and closed modals.

Rename the orphan-tile test to match its assertion and verify the
seven-tile layout across desktop and mobile widths. Wait for the
asynchronous clipboard success state before asserting it, then check
that the clipboard contains the exact timeline URL.

Co-Authored-By: GPT 6.1 Sol <noreply@openai.com>
@LukasWallrich
LukasWallrich merged commit a600e04 into main Oct 21, 2026
3 checks passed
@LukasWallrich
LukasWallrich deleted the fix/chart-details branch October 21, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant