Repository navigation
fix: temporarily disable duplicate newsletter form on homepage - #914
Open
richarddushime wants to merge 1 commit into
Open
richarddushime wants to merge 1 commit into
richarddushime wants to merge 1 commit into
Conversation
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
✅ Spell Check PassedNo spelling issues found when checking 1 changed file(s)! 🎉 |
Contributor
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-10-21 13:29:42 UTC The staging site shows the combined state of all compatible open PRs. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #913
Problem
Embedding the same EmailOctopus form snippet twice on the homepage causes a JavaScript
data-formID conflict, preventing the second instance from rendering/submitting properly. Resolving this natively requires duplicating the form in the EmailOctopus dashboard.What i did
Next Steps
Pending confirmation from the team lead on our EmailOctopus plan, we will re-enable the second homepage placement by creating a duplicate embeddable form with a unique ID in the EmailOctopus dashboard.
Confirmation
This PR can go ahead as is because creating a duplicate will not be possible due to the current emailoctopus plan.
@LukasWallrich
Type of Change
Testing
Checklist
Notes
Summary by cubic
Temporarily removes the duplicate newsletter form on the homepage so the remaining form stops breaking from a JavaScript
data-formID conflict when the same EmailOctopus snippet is embedded twice.Re-enable the second placement once a duplicate form with a unique ID is created in the EmailOctopus dashboard. Forms on other pages load a single instance and remain unaffected.
Written for commit b82816a. Summary will update on new commits.