ui/login - #251
Draft
MiloCasagrande wants to merge 8 commits into
Draft
Conversation
MiloCasagrande
commented
Aug 28, 2026
MiloCasagrande
commented
Member
- ui: add login.css for the redesigned login pages
- ui: redesign local-login page
- ui: redesign oauth2-login page for GitHub
- ui: redesign oauth2-login page for Google
- test: add e2e coverage for the local login flow
- fix: check if there is no cookie and suppress error
- fix: correctly override pico color vars
- style: bump root font to 16px, add fluid type scale for headings
added 8 commits
August 28, 2026 10:08
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
The new UI will show an error the first time a user arrives at the login page and there is no cookie set. Silence that error so it does not pop up in the UI. Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
Replace the 15px root override with 16px (browser baseline, cleaner rem math). Add Minor-Third-based heading scale using --pico-font-size overrides so Pico's own rules read the values without a specificity fight. h1–h3: fluid via clamp() (22–28 / 18–22 / 16–19 px across 320–1280px) h4–h6: fixed (17 / 13 / 11 px) — hierarchy carried by weight and case. Signed-off-by: Milo Casagrande <mcasagra@qti.qualcomm.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+67
to
+78
| <form method="post" action="/auth/login"> | ||
| {{ if .CsrfToken }}<input type="hidden" name="_csrf" value="{{.CsrfToken}}">{{ end }} | ||
| <fieldset> | ||
| <label for="username">Username</label> | ||
| <input type="text" id="username" name="username" autocomplete="username" autocapitalize="none" spellcheck="false" required> | ||
| </fieldset> | ||
| <fieldset> | ||
| <label for="password">Password</label> | ||
| <input type="password" id="password" name="password" autocomplete="current-password" required> | ||
| </fieldset> | ||
| <button type="submit">Sign in</button> | ||
| </form> |
doanac
approved these changes
Aug 28, 2026
doanac
left a comment
doanac
left a comment
Member
There was a problem hiding this comment.
LGTM - I've tested all three providers and they look good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.