CodeRabbit review findings - #5
Merged
Merged
Conversation
README documents exit code 125 for invalid usage, and validateArgs errors honor that, but a malformed flag never reaches the action: cli.Command.Run returns the parse error to main, where log.Fatal exits with status 1, breaking the documented contract. Set OnUsageError to route parse errors through the same cli.Exit(..., 125) path as other usage errors. This also reports the error once, in the ERROR: prefix style, instead of twice: previously cli printed "Incorrect Usage" plus a full help dump and logrus then repeated the message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The intent of requiring 1.26.5 (the crypto/tls fix for GO-2026-5856) was expressed as go 1.26 plus a toolchain directive, but the toolchain directive is only a suggestion: it is honored under the default GOTOOLCHAIN=auto and silently ignored under GOTOOLCHAIN=local, where a 1.26.0 toolchain would build a binary without the fix. The go directive is the mechanism that actually enforces a floor - an older toolchain either auto-upgrades or fails loudly. Raise the go directive to 1.26.5 and drop the now-redundant toolchain line. The module is not importable as a library, so the stricter directive burdens no dependents. CI stays on go-version: '1.26', which setup-go resolves to the latest 1.26.x patch, so release builds keep picking up future security fixes without manual bumps. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ErikBooijFR
marked this pull request as ready for review
August 12, 2026 08:47
ankon
approved these changes
Aug 12, 2026
ankon
left a comment
ankon
left a comment
There was a problem hiding this comment.
If this were my project I'd not do the readme thing (completely remove the go version). But it isn't, and this is likely what they will accept in the upstream PR, so: All good, ship it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When offering our fixes to the upstream repo (gmr#24), their automated CodeRabbit review came up with two more small issues. Fixed in that PR, carrying them over to our fork here.