Locale sync - fix possible out of memory export crash - #686
Merged
Conversation
djohalo2
changed the title
djohalo2
marked this pull request as ready for review
August 18, 2026 06:38
github-actions
Bot
added
the
Auto submit to Marketplace on merge
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Locale Sync plugin export flow to use the newer @framer/plugin API and iterates localization groups via listLocalizationGroups() during export, aiming to reduce the risk of out-of-memory crashes. It also adds an exporting/loading UI state to the Export button.
Changes:
- Migrated Locale Sync from
framer-pluginto@framer/plugin(dependency + imports). - Updated XLIFF export to gather localization groups via
framer.listLocalizationGroups()and added exporting state/disabled+spinner UX. - Updated lockfile to include the new
@framer/plugin@4.2.0-beta.0resolution for this workspace.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| yarn.lock | Adds @framer/plugin@4.2.0-beta.0 and wires locale-sync workspace dependency to it. |
| plugins/locale-sync/src/xliff.ts | Switches localization type imports from framer-plugin to @framer/plugin. |
| plugins/locale-sync/src/App.tsx | Uses listLocalizationGroups() for export and adds export loading/disabled UI state. |
| plugins/locale-sync/package.json | Replaces framer-plugin dependency with @framer/plugin@4.2.0-beta.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
djohalo2
force-pushed
the
fix/export-crash-large-localization-groups
branch
from
August 18, 2026 06:52
1198e1f to
2940f3b
Compare
elmarburke
reviewed
Aug 18, 2026
djohalo2
force-pushed
the
fix/export-crash-large-localization-groups
branch
from
August 18, 2026 08:08
a3bc298 to
0d9d9fb
Compare
elmarburke
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To fix a possible out of memory crash in the Locale Sync plugin export, this pull request implements the new
listLocalizationGroupsmethod to get localization groups using async iterator when exporting. While at it I also added a loading state to the button.Changelog
Testing