Repository navigation
test(cleanroom): install proof9 from the published marketplace and run its tests - #1540
Conversation
…n its tests The cold-start harness has validated the CLI path end to end on every release and caught real defects, including a published 0.9.2 that could not run at all — found only because it installed from PyPI rather than from source. It never touched proof9: no Claude Code in the image, no reference to the plugin. Since the README's first screen now leads with the plugin install, the lead path was the one never tested cold. After the timed CLI walkthrough, and outside its total (that total is the figure the README quotes), the harness now runs the README's shell install, `claude plugin install proof9 --marketplace frankbria/codeframe`, then checks the installed copy is enabled, validates it, and runs its own test suite from there. CI tests the plugin in the repository; this tests what a stranger gets. Verification steps are marked documented=check so they do not read as docs drift; failures file P-PLUGIN-* findings. The image gains Claude Code on Node 22, pinned to the version CI tests the plugin against. tests/ci/test_cleanroom_plugin_path.py keeps the two pins equal and the install pointed at the published marketplace. Verified by building the image and running the plugin section of walkthrough.sh in it: install, enabled, validate and test all OK; 176 plugin tests pass from the installed copy. Full CI selection: 6043 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019cEymaSpmZ1arjngxx1VNM
|
Claude finished @frankbria's task in 7m 24s —— View job Claude PR Review — cleanroom plugin path
Result: no defects found. Full sweep notes are in the review-summary comment below. |
ReviewThis closes a real gap: the README lead path (plugin install) was never exercised by the cold-start harness. Keeping the plugin section outside the timed total preserves the quoted figure, and Suggestions
Overall a good, low-risk change. I would address (1) and (2) before relying on the findings it files. |
|
✅ Third Party Review: no defects found. Scope swept: the four changed files plus their consumers ( Verified clean, among others:
Model: k3[1m] |
The cold-start harness validates the CLI path on every release and has caught real defects — including a published
0.9.2that could not run at all, found only because it installed from PyPI rather than from source. It never touched proof9: no Claude Code in the image, no reference to the plugin anywhere in it. With #1531 the README leads with the plugin install, so the lead path was the untested one.What it does now
After the timed CLI walkthrough — and outside its total, which is the figure the README quotes — the harness:
documentedplugin-installclaude plugin install proof9 --marketplace frankbria/codeframe, exactly as the README documents it, from the published marketplaceplugin-enabledplugin-validateclaude plugin validateon the installed copyplugin-testdocumented=checkis new: a verification on the published artifact, not a user step, so it doesn't read as docs drift (which is whatdocumented=nomeans). Failures fileP-PLUGIN-*findings like the rest of the harness.CI already runs
claude plugin validate ./proof9andclaude plugin test ./proof9— against the plugin in the repository. This checks what a stranger receives.Supporting changes
2.1.301).tests/ci/test_cleanroom_plugin_path.pykeeps the two pins equal and the harness pointed at the published marketplace rather than a local path.documented=checkand the published-artifact principle.Verification
walkthrough.shin it:plugin-install,plugin-enabled,plugin-validate,plugin-testall OK; 176 plugin tests pass from the installed copy; no findings.uv run pytest tests/ --ignore=tests/e2e -m "not lifecycle"→ 6043 passed, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_019cEymaSpmZ1arjngxx1VNM