Favorite renaming - #30
Open
Lyinlyon wants to merge 10 commits into
Open
Conversation
new file: drizzle/0003_favorites_add_name.sql modified: package-lock.json modified: package.json modified: src/__test_utils__/seed.ts modified: src/backend/routes/favorites.test.ts modified: src/backend/routes/favorites.ts modified: src/frontend/cards/card-components.tsx modified: src/frontend/favorites/favorite-button.tsx modified: src/frontend/favorites/favorite-card.tsx modified: src/frontend/favorites/favorite-menu.tsx modified: src/shared/api-models.ts modified: src/shared/schema.ts
new file: src/frontend/favorites/favorite-search.test.ts new file: src/frontend/favorites/favorite-search.ts modified: src/frontend/favorites/favorites-list.tsx modified: src/shared/search.ts
modified: src/frontend/favorites/favorite-menu.tsx
modified: src/backend/routes/favorites.test.ts modified: src/backend/routes/favorites.ts
AlexKempen
reviewed
Jul 12, 2026
AlexKempen
reviewed
Jul 12, 2026
AlexKempen
requested changes
Jul 13, 2026
AlexKempen
left a comment
AlexKempen
left a comment
Collaborator
There was a problem hiding this comment.
It's looking good, you can see my comments above.
I also realized our search logic was pretty scuffed and/or scattered, so I added a typed SearchResultDocument helper and renamed/re-organized our existing search implementation so the organization is a bit clearer, so make sure you run git pull the next time you work on it so you get my changes/don't run into conflicts
deleted: coverage/coverage-final.json deleted: coverage/lcov-report/base.css deleted: coverage/lcov-report/block-navigation.js deleted: coverage/lcov-report/favicon.png deleted: coverage/lcov-report/index.html deleted: coverage/lcov-report/prettify.css deleted: coverage/lcov-report/prettify.js deleted: coverage/lcov-report/sort-arrow-sprite.png deleted: coverage/lcov-report/sorter.js deleted: coverage/lcov.info
modified: src/frontend/cards/card-components.tsx modified: src/frontend/cards/insertable-card.tsx modified: src/frontend/favorites/favorite-card.tsx modified: src/frontend/groups/group-card.tsx modified: src/shared/schema.ts
Lyinlyon
marked this pull request as draft
August 6, 2026 01:35
modified: src/frontend/favorites/favorite-search.ts
Lyinlyon
marked this pull request as ready for review
August 6, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Favorites can now be renamed inline. The favorite search now searches by the favorite id and name rather than the insertable. The changes to packages and the addition of the coverage folder were done automatically and I have no idea what they do.