Fix consistency across component and vendor naming - #163
Open
reniejoshi wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
Curriculum material
|
🌐 Preview URL: https://pr-163.frcsoftware.pages.dev |
DylanB5402
reviewed
Aug 1, 2026
DylanB5402
reviewed
Aug 6, 2026
| class Intake implements Mechanism { | ||
| // Store any motors specific to the mechanism as private members. | ||
| // This can include TalonFX, SparkMax and/or SparkFlex instances. | ||
| // This can include TalonFX, Spark Max and/or Spark Flex instances. |
Member
There was a problem hiding this comment.
Sorry for taking a while to take another look at this. It looks like we define them as Spark MAX and Talon FX in our Vale glossary. Should we match that for consistency?
cc @zachwaffle4 maybe?
Member
There was a problem hiding this comment.
REV calls them "SPARK MAX" So it should probably be changed to that?
Contributor
|
I think that in code comments it makes sense to keep TalonFX, SparkMax, SparkFlex to match the class names. |
DylanB5402
approved these changes
Aug 8, 2026
DylanB5402
left a comment
DylanB5402
left a comment
Member
There was a problem hiding this comment.
Matching class names in code works for me, we can always revisit later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Spark Max and SystemCore casing and spacing across multiple files.
Closes #158.
Meta
Merge checklist: