Skip to content

docs(plan): dotfiles ci, done #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredericrous merged 1 commit into from
Sep 29, 2026
Merged

docs(plan): dotfiles ci, done #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions docs/plans/2026-09-30-dotfiles-ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
status: active
status: done
branch: feat/ci
repos: [dotfiles]
adrs: [ADR-0017]
Expand Down Expand Up @@ -196,11 +196,10 @@ repository has no language of its own.
(stdin, never argv), otherwise the first same-repository run fails by
design. Then F4b (the first real implementation review), push, both
runners green, merge.
- [ ] Phase 4 — record the F4b cycle (tokens, seconds, verdict, whether
- [x] Phase 4 — record the F4b cycle (tokens, seconds, verdict, whether
each finding was real) in the implementation-review plan's Verification,
in decisions, as its Phase 4; set that plan's Phase 4 ticked. (Opened
right after this PR merges; this plan's tick rides the next dotfiles
change.)
in decisions, as its Phase 4; set that plan's Phase 4 ticked. → decisions#33
(merged 2026-09-30, c5ff2d3).

## Decision log

Expand Down Expand Up @@ -297,6 +296,15 @@ repository has no language of its own.

## Outcome

(filled when the plan closes)
Shipped 2026-09-30 in dotfiles#14: `make check` (pinned tools, hermetic
render, shellcheck, tree-wide private-refs) mirrored by GitHub Actions on
Linux and macOS, green on both; the repository's first CI, and the first
live implementation-review cycle, which caught one real defect (a
malformed regex passing the private-refs check silently) before the push.
Surprises: the shebang rule pulled six git helper scripts into lint and
found two real bugs in them; the shell lexer strips an unquoted Windows
path's backslashes (not this repository's concern, but the same evening's
amont-agent lesson); the reviewer's Bash guard refused a read of its own
pass files (amont-agent#61). Nothing left open here.

<!-- panel: repos=dotfiles adds=ops reviewers=backend,platform body-sha=f5d3133cd045 -->
Loading