Skip to content

feat(claude): the last commit closes the plan #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredericrous merged 1 commit into from
Sep 30, 2026
Merged

feat(claude): the last commit closes the plan #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions dot_claude/skills/worktree-task/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,10 @@ below names one of them.
count against the budget.
- **F3. Record.** In the plan: input → expected → actual per check, tick
the phases, append Decision log / Outcome. Set `status: done` only if
verification passed AND this PR implements the last phase. Offer to turn
verification passed AND this PR implements the last phase. Record only
what was observed before the push: never a "pending" row for CI, the
merge or a release — those live in the PR checks and the tag
(`work.plan-closes-with-the-branch`). Offer to turn
a lasting decision into an ADR in this same PR
(`work.lasting-decisions-become-adrs`). Screenshots and raw output go
OUTSIDE the worktree (`~/.claude/amont-agent/attestations/<sha>/`).
Expand Down Expand Up @@ -185,9 +188,15 @@ below names one of them.
4. Post `returned: <verdict> (<tokens>, <seconds>)`.
5. Record it in the plan under `## Implementation review`, at most 5
lines of about 20 words, verdict first: the verdict; findings fixed;
findings kept as `deliberate: <reason>`; tokens and seconds. Commit
`docs(plan): implementation review`. The canonical tree does not
change, so the review stays bound.
findings kept as `deliberate: <reason>`; tokens and seconds. This is
the branch's **closing commit** (`work.plan-closes-with-the-branch`),
the counterpart of the plan commit that opened it: in the same commit
set `status: done` (or keep `active` and name the next phase), with
every Verification row holding its observed result and none pending.
Commit `docs(plan): <slug>, done` (or `…, phase N`). The canonical
tree does not change, so the review stays bound. It stays the LAST
commit: anything committed after it (a CI fix) returns to F1, and the
closing commit is made again on top.
6. `approve`, or `approve-with-changes` with every finding fixed or
named deliberate: continue to F5. A fix that changes code returns to
F1, and the **second** pass through F4b is the `Delta`: a fresh block
Expand Down
Loading