Repository navigation
ghostty: keep Hyper chords off the menu bar so herdr gets them - #19
Merged
Merged
Conversation
Ghostty shows the last binding for an action as its menu shortcut, so New Tab, Split Right and Close carried the Hyper chords. macOS fires a menu shortcut before any key table, so the herdr table never saw them. performable: bindings never become menu shortcuts (Binding.zig reverse map), which leaves the menus on the Command defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside herdr, Hyper-C still opened a Ghostty tab. Ghostty uses the most recently defined binding for an action as that action's menu shortcut, so File ▸ New Tab, Split Right and Close showed ⌃⌥⌘C, ⌃⌥⌘I and ⌃⌥⌘X. macOS fires menu shortcuts before Ghostty looks at key tables, so the
herdrtable'sunbindlines never got a chance to run.performable:, which Ghostty 1.3.1 leaves out of menu shortcuts (src/input/Binding.zig, reverse map). The menus go back to ⌘T, ⌘D and the other Command defaults.test.shfails if a Hyper action binding losesperformable:.Side effect: a Hyper chord whose action can't run (for example moving to a split when there is none) now reaches the shell instead of being swallowed.