Repository navigation
ghostty: make the herdr key table actually pass Hyper chords through - #20
Merged
Merged
Conversation
In Ghostty 1.3.1, unbind inside a key table only removes the table's own entry, so the lookup fell through to the default bindings and Hyper-C still ran new_tab with the table active. Each table entry is now a performable activate_key_table:herdr. With herdr already innermost that is a no-op returning false, and an unperformed performable binding sends the key to the pty.
froppa
enabled auto-merge (squash)
October 7, 2026 07:29
froppa
disabled auto-merge
October 7, 2026 07:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
herdrkey table active, Hyper-C still opened a Ghostty tab. In Ghostty 1.3.1,unbindinside a table only deletes the table's own entry for that chord (Binding.zigSet.remove). The lookup then finds nothing in the table and falls back to the default bindings (Surface.zig), whatever the docs say.herdr/entry is nowperformable:<chord>=activate_key_table:herdr. Withherdralready the innermost table, Ghostty ignores that activation and reports it as not run. An unperformedperformable:binding is treated as if it didn't exist, so Ghostty sends the key to herdr.test.shchecks that the table covers every Hyper chord Ghostty binds and fails if an=unbindline comes back in the table.