NuGet packaging of DesignTime DLL for F# provider#583
Conversation
|
@T-Gro, I discovered that the design-time DLL is no longer packaged into the NuGet package. |
6fee6bf to
4a3480d
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts NuGet packaging for the FSharp.Data.GraphQL.Client type provider so the *.DesignTime.dll is included in the produced package, working around limitations in the F# SDK/MSBuild packing flow when a runtime project references its design-time project via ProjectReference.
Changes:
- Adds a custom target hooked via
TargetsForTfmSpecificContentInPackageto inject the DesignTime DLL into the package. - Removes the previously-used
RemoveUnnecessaryNuGetPackInputtarget and cleans up NuGet-related conditions for consistency. - Updates
ProjectReference/PackageReferenceconditions to use quoted$(IsNuGet)comparisons.
| <MSBuild Projects="@(_DesignTimeProjectRef)" | ||
| Targets="GetTargetPath" | ||
| Properties="Configuration=$(Configuration);TargetFramework=netstandard2.0"> | ||
| <Output TaskParameter="TargetOutputs" ItemName="_DesignTimeDllPath" /> |
95a0820 to
79bdced
Compare
Added MSBuild target to ensure DesignTime DLL is included in NuGet package, working around F# SDK limitations with ProjectReference-based providers. Removed obsolete target for cleaning NuGet pack input and updated conditions for consistency.
79bdced to
56419ea
Compare
Test Results 3 files 3 suites 9m 58s ⏱️ Results for commit 56419ea. |
|
@xperiandri : I will take a look and write here 👍 |
|
@xperiandri heads-up: the root cause behind this workaround is being fixed upstream in dotnet/fsharp#19979. Once that ships in a future .NET SDK, the custom |
Added MSBuild target to ensure DesignTime DLL is included in NuGet package, working around F# SDK limitations with ProjectReference-based providers. Removed obsolete target for cleaning NuGet pack input and updated conditions for consistency.