Repository navigation
build(nix): take lefthook from nixpkgs-unstable - #4
Merged
Merged
Conversation
lefthook before 2.1.6 runs hook commands under a pty, which agent sandboxes deny, so commits made inside the devShell failed in their hooks. Take only lefthook from a new nixpkgs-unstable input and keep every other package on the existing nixpkgs. Refs furedea/dotfiles#207 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nixpkgs-unstableflake input and take onlylefthookfrom it in the devShell. Every other package stays on the existingnixpkgs(25.11-darwin).flake.lockonly gains the newnixpkgs-unstableentry; the existingnixpkgslock is unchanged.Why
The devShell's lefthook came from nixpkgs 25.11 (1.13.6). lefthook before 2.1.6 runs hook commands under a pty, which agent sandboxes deny, so commits made inside
nix developfailed in their hooks. This mirrors the fix already used in furedea/dotfiles.Verification
nix develop -c lefthook version→2.1.15nix flake checkpassesnix develop -c lefthook run pre-commit --all-files: deadnix, ls-lint, nixfmt, statix, fmt, jxa-lint, jxa-format, typecheck pass. clippy failed only because the sandbox denies writes to~/.cargo/registry; withCARGO_HOME/CARGO_TARGET_DIRpointed at a temp dir,cargo clippy -- -D warningspasses.nix develop -c git commitwith lefthook enabled inside the sandbox: pre-commit (deadnix, ls-lint, nixfmt, statix) and commit-msg (commitlint) hooks ran under lefthook v2.1.15 and passed.Refs furedea/dotfiles#207
🤖 Generated with Claude Code