Repository navigation
Fix SwiftLint findings and adopt company SwiftFormat config - #69
Merged
Merged
Conversation
Move the access modifier from the extension to the declaration and replace the force unwrap in the merge loop with a fallback to the item itself, which is equivalent since the dictionary is built from newItems. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copy .swiftformat from iOS-project-template so the library follows the same style as generated projects. Swift version pinned to 6.1 to match Package.swift; Templates excluded because SwiftFormat would alter the //___FILEHEADER___ placeholder and the templates are formatted separately. Keep explicit self in AttributedStringProtocol.stylize(with:), where the attributes are dynamic members and redundantSelf breaks compilation. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
jmarek41
enabled auto-merge
September 4, 2026 08:11
ssestak
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.swiftlint.yml: access modifier moved frompublic extension ConfigKeyto the declaration, and the force unwrap inDataCache.mergingreplaced with?? item(equivalent, the dictionary is built fromnewItems; covered by the "duplicate IDs, last wins" test)..swiftformatfrom iOS-project-template and apply it toSourcesandTests. Mostly indentation inside#ifblocks and redundantself; the only public signature changes are unused parameter names becoming_.Templatesare excluded because the formatter alters the//___FILEHEADER___placeholder.selfkept inAttributedStringProtocol.stylize(with:), where attributes are dynamic members.Verified:
swiftlintandswiftformat --lintreport zero issues, and the test suite passes (15 tests) on Xcode 27.