Skip to content

fix: JSON Schema number type should also include int #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korikuzma merged 1 commit into from
Jul 2, 2026
Merged

fix: JSON Schema number type should also include int #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ga4gh/va_spec/base/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class CohortAlleleFrequencyStudyResult(_StudyResult, BaseModelForbidExtra):
...,
description="The number of occurrences of all alleles at the locus in the cohort.",
)
focusAlleleFrequency: float = Field(
focusAlleleFrequency: int | float = Field(
..., description="The frequency of the focusAllele in the cohort."
)
cohort: StudyGroup = Field(
Expand Down Expand Up @@ -274,7 +274,7 @@ class TumorVariantFrequencyStudyResult(_StudyResult, BaseModelForbidExtra):
...,
description="The total number of tumor samples in the sample group.",
)
affectedFrequency: float = Field(
affectedFrequency: int | float = Field(
...,
description="The frequency of tumor samples that include the focus variant in the sample group.",
)
Expand All @@ -301,7 +301,7 @@ class ExperimentalVariantFunctionalImpactStudyResult(
...,
description="The genetic variant for which a functional impact score is generated.",
)
functionalImpactScore: float | None = Field(
functionalImpactScore: int | float | None = Field(
default=None,
description="The score of the variant impact measured in the assay or study.",
)
Expand Down Expand Up @@ -572,7 +572,7 @@ class EvidenceLine(InformationEntity, BaseModelForbidExtra):
default=None,
description="The strength of support that an Evidence Line is determined to provide for or against its target Proposition, evaluated relative to the direction indicated by the directionOfEvidenceProvided value.",
)
scoreOfEvidenceProvided: float | None = Field(
scoreOfEvidenceProvided: int | float | None = Field(
default=None,
description="A quantitative score indicating the strength of support that an Evidence Line is determined to provide for or against its target Proposition, evaluated relative to the direction indicated by the directionOfEvidenceProvided value.",
)
Expand Down Expand Up @@ -749,7 +749,7 @@ class Statement(InformationEntity, BaseModelForbidExtra):
default=None,
description="A term used to report the strength of a Proposition's assessment in the direction indicated (i.e. how strongly supported or disputed the Proposition is believed to be). Implementers may choose to frame a strength assessment in terms of how *confident* an agent is that the Proposition is true or false, or in terms of the *strength of all evidence* they believe supports or disputes it.",
)
score: float | None = Field(
score: int | float | None = Field(
default=None,
description="A quantitative score that indicates the strength of a Proposition's assessment in the direction indicated (i.e. how strongly supported or disputed the Proposition is believed to be). Depending on its implementation, a score may reflect how *confident* that agent is that the Proposition is true or false, or the *strength of evidence* they believe supports or disputes it. Instructions for how to interpret the meaning of a given score may be gleaned from the method or document referenced in 'specifiedBy' attribute.",
)
Expand Down
Loading