Skip to content

Grouped mutation calls mutate before validation and skip empty groups #1141

Closed

Description

@tturocy

This boils down to this loop:

for group in self._group_nodes(nodes).values():
    if not group:
        continue
    self._append_move_at(group, player, actions)

This does the append without checking everything's going to work OK, and empty groups are skipped silently. Meanwhile though, an empty list (ungrouped) raises an exception.

This issue will affect any by-group-enabled method, see #1140 as well.

Activity

  1. self-assigned this
    on Sep 15, 2026
  2. added
    cythonItems which involve coding in Cython
    on Sep 15, 2026
  3. added this to the gambit-17.0.0 milestone on Sep 15, 2026
  4. tturocy commented on Sep 28, 2026

    @tturocy
    MemberAuthor

    Closed by #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cythonItems which involve coding in Cython

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions