Repository navigation
Conversation
This breaks `gtdraw`; test is currently `xfail` pending us updating it.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
Author
|
@rahulsavani @d-kad For discussion and next action - these changes break |
Member
Author
|
This has been accomplished by another line of work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
Actionfrompygambit(as a direct wrapper holding a shared pointer to internal Game objects).Actions are now principally referred to simply by their labels, as they are required to be nonempty and unique within their scope (information set/event).
Where required for context, an
ActionorBranchnamed tuple is provided (to link the action label to its corresponding information set/event or node, respectively).